Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): pin TypeScript below 3.7.0 #1163

Merged
merged 1 commit into from
Dec 6, 2019
Merged

fix(deps): pin TypeScript below 3.7.0 #1163

merged 1 commit into from
Dec 6, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Dec 5, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
@bcoe
Copy link
Contributor Author

bcoe commented Dec 5, 2019

@kjin 👋 unfortunately, TypeScript@3.7.0 is not compatible with 3.5.3 (which is the version Angular is pinned to, and a lot of our users use).

Any thoughts on the failing circle-ci tests here?

@kjin
Copy link
Contributor

kjin commented Dec 6, 2019

@bcoe I was OOO yesterday, will look at them today. Thanks for the reminder!

If it's urgent, please force-merge this PR.

@bcoe
Copy link
Contributor Author

bcoe commented Dec 6, 2019

@kjin I would say medium urgent, it means our TypeScript folks on Angular can't run trace; I don't have permission to force push unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants